Skip to content

Conversation

raupachz
Copy link

Bugfix for Issue #10985.

This code only extends commit 46d93dab.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be able to parse 4.0.0 POM files with no namespace, but that is not allowed for 4.1.0 POM files.
I'm not sure we want to restrict namespaces when reading 4.0.0 files. That can be checked for build POM, but not when consuming them from a repository. So we need to make that dependent on the validationLevel to preserve compatibility.

@raupachz
Copy link
Author

...

@raupachz
Copy link
Author

We need to be able to parse 4.0.0 POM files with no namespace, but that is not allowed for 4.1.0 POM files.
I'm not sure we want to restrict namespaces when reading 4.0.0 files. That can be checked for build POM, but not when consuming them from a repository. So we need to make that dependent on the validationLevel to preserve compatibility.

Thanks. I did not know that. It looked simpler from the bug description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants