Drop legacy duplicated code #11501
Draft
Drop legacy duplicated code #11501
+44
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now Maven 4 (same as 3) contains duplicated code to read update status, and due this in-JVM but also process wide synchronization is needed. For start, drop Maven legacy code and use resolver component to perform reads.
Member
Author
|
cherry pick from: |
Member
|
Looks good, will pass once Resolver 1.9.25 is out. |
cstamas
reviewed
Dec 8, 2025
| /** | ||
| * DefaultUpdateCheckManager | ||
| */ | ||
| @Component(role = UpdateCheckManager.class) |
Member
There was a problem hiding this comment.
Unsure would I migrate this from plx to sisu; moreover, undoing this change will make other UT changes unneeded (index scanning)
Member
Author
There was a problem hiding this comment.
I afraid that I need add scaning to UT as implementation of TrackingFileManager is sisiu
cstamas
reviewed
Dec 8, 2025
| private static final String ERROR_KEY_SUFFIX = ".error"; | ||
|
|
||
| public DefaultUpdateCheckManager() {} | ||
| @Inject |
Member
There was a problem hiding this comment.
Just make/leave this plain old plx component with field injection instead, and as said above, it will leave things less intrusive re UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Maven 4 (same as 3) contains duplicated code to read update status, and due this in-JVM but also process wide synchronization is needed.
For start, drop Maven legacy code and use resolver component to perform reads.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.