Download binaries task is broken #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
approved these changes
Jun 21, 2019
|
I discovered the problem while working on oracle/visualvm#137 CCing @thurka |
neilcsmith-net
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that my f2c5275 causes a regression.
DownloadBinariestask fromharness/tasks.jaris unusable as theharness/tasks.jarmisses now necessaryConfigureProxyclass.To prevent such unfortunate error I wanted to write a test. My attempts to unit test the task failed and at the end I decided to do 022de83
The fix then was simple: 02b8d54