Master Filesystem Valhalla compatibility #8964
Open
+527
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Platform
This comment was marked as off-topic.
This comment was marked as off-topic.
This is not about editor support for JDK 26 or any editor features regarding value types. This PR so far is just here to allow (very) early testing of running NB on ea JDKs which have the JEP 401 implementation enabled. |
mbien
force-pushed
the
valhalla
branch
2 times, most recently
from
8b5381f to
561766c
Compare
The WeakHashMap keys, which are used to track the lifecycle of BaseFileObj, must be identity objects. This is also a bugfix, since Integers are bad reference strength indicators due to the internal Integer boxing cache.
Language level bump, overrides and simplifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first commit fixes the internal reference tracking
WeakHashMap:WeakHashMapkeys, which are used to track the lifecycle ofBaseFileObj, must be identity objects.Integersare bad reference strength indicators due to the internalIntegerboxing cache - some are always strongly reachablesecond commit is for module cleanup
tested using:
26-jep401ea2+1-1(don't forget-J--enable-preview)NB starts and projects load at least, but more work may be needed in other areas (did only very basic testing).
meta issue #8256