Skip to content

Conversation

@martinzink
Copy link
Member

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink force-pushed the remove_extension_list branch 3 times, most recently from aa84b3d to 015405e Compare November 18, 2025 07:36
@martinzink martinzink marked this pull request as ready for review November 18, 2025 15:54
@szaszm
Copy link
Member

szaszm commented Nov 18, 2025

I see these errors in the CI linter job:

2025-11-18T07:37:44.5872514Z minifi-api/include/minifi-c/minifi-c.h:219:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:44.8682008Z minifi-api/include/minifi-cpp/core/ControllerServiceApi.h:29:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:44.8922217Z minifi-api/include/minifi-cpp/core/DynamicProperty.h:30:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:44.9368808Z minifi-api/include/minifi-cpp/core/OutputAttribute.h:34:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:50.4177139Z libminifi/src/minifi-c.cpp:350:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4292092Z libminifi/src/minifi-c.cpp:420:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4297971Z libminifi/src/minifi-c.cpp:424:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4314965Z libminifi/src/minifi-c.cpp:435:  Lines should be <= 200 characters long  [whitespace/line_length] [2]

@martinzink
Copy link
Member Author

I see these errors in the CI linter job:

2025-11-18T07:37:44.5872514Z minifi-api/include/minifi-c/minifi-c.h:219:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:44.8682008Z minifi-api/include/minifi-cpp/core/ControllerServiceApi.h:29:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:44.8922217Z minifi-api/include/minifi-cpp/core/DynamicProperty.h:30:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:44.9368808Z minifi-api/include/minifi-cpp/core/OutputAttribute.h:34:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
2025-11-18T07:37:50.4177139Z libminifi/src/minifi-c.cpp:350:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4292092Z libminifi/src/minifi-c.cpp:420:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4297971Z libminifi/src/minifi-c.cpp:424:  Lines should be <= 200 characters long  [whitespace/line_length] [2]
2025-11-18T07:37:50.4314965Z libminifi/src/minifi-c.cpp:435:  Lines should be <= 200 characters long  [whitespace/line_length] [2]

Yeah those come from the c-api PR (I've targeted that instead of main)

@martinzink martinzink force-pushed the apache-processor-c-api branch 2 times, most recently from 76203cd to 4af23b2 Compare November 27, 2025 09:09
@martinzink martinzink force-pushed the remove_extension_list branch from c1a81f3 to 29e2c63 Compare November 27, 2025 10:20
@martinzink martinzink force-pushed the remove_extension_list branch from cfe04bf to b4c0419 Compare December 2, 2025 16:56
@martinzink martinzink changed the base branch from apache-processor-c-api to main December 2, 2025 16:56
@martinzink martinzink force-pushed the remove_extension_list branch from b4c0419 to c08497b Compare December 2, 2025 16:59
@szaszm szaszm closed this in 098dab1 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants