oot ci build test #3185
oot ci build test #3185
Conversation
| @@ -0,0 +1,35 @@ | |||
| cmake_minimum_required(VERSION 3.12...3.31) | |||
There was a problem hiding this comment.
do we need add Kconfig?
There was a problem hiding this comment.
no this cannot be built using using classical apporaches. The aim to to build only out of tree using the export
There was a problem hiding this comment.
What about people using Make and Kconfig? Would it build for them? Please provide steps how to reproduce in Testing section. Thanks :-)
There was a problem hiding this comment.
the aim was just to have add a out of tree ci test, and not necessarily expose this as a testing app, but if you guys want i can look into it, but keep in mind the build via Kconfig and make is not a representative test for what we intended to do. It's a simple oot of tree build test to prevent regressions when packaging nuttx export, the app itself doesn't do much :).
There was a problem hiding this comment.
@cederom where is the testing section. I'll add a link in the section orienting users to the doc in nuttx, Once i address this comment apache/nuttx#17017 (comment) from @acassis
|
@xiaoxiang781216 should i also add the same stage to the github action in the app? I feel like there is not need, but the build.yml seems to closesly mirror the build.yml from the nuttx repo |
| @@ -0,0 +1,2 @@ | |||
| build/ | |||
| nuttx-export* No newline at end of file | |||
There was a problem hiding this comment.
Thank you @trns1997 :-) Please take a look at [1] [2] [3] and update git commit message and PR description to match requirements :-)
[1] https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
[2] https://nuttx.apache.org/docs/latest/contributing/index.html
[3] https://nuttx.apache.org/docs/latest/contributing/coding_style.html
Note: Please adhere to Contributing Guidelines.
Summary
Issue: #17016
Depends-on: apache/nuttx#17017
Impact
Testing