Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Apr 21, 2025

Which issue does this PR close?

part of #5366 .
part of #1741

Rationale for this change

What changes are included in this PR?

add c async stat support

Are there any user-facing changes?

user can use c async stat.

@asukaminato0721 asukaminato0721 changed the title C async feat(bindings/c): async stat Apr 21, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review April 21, 2025 06:48
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Apr 21, 2025
@asukaminato0721 asukaminato0721 force-pushed the c-async branch 2 times, most recently from 1799b3c to 8b4901e Compare April 22, 2025 09:48
@Xuanwo
Copy link
Member

Xuanwo commented Apr 23, 2025

Hi, I tend to leave the C binding AS IS until we have an actual user utilizing the C binding in a production environment who can show us how they use the library’s async API. Alternatively, we could wait until we have a comprehensive design for how the C binding’s async functionality should work. For example, how should we handle the existing Tokio code? Should we consider splitting the library into a blocking version and an async version? We can wait for #6082 to reach a consensus.

I'm concerned about choosing a direction without sufficient information. In fact, the C binding itself is powered by Tokio, which runs all I/O asynchronously, but currently, we only provide users with a blocking API.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 22, 2025
@asukaminato0721 asukaminato0721 changed the title feat(bindings/c): async stat feat(bindings/c): async stat, read, write ,delete Nov 22, 2025
@asukaminato0721 asukaminato0721 force-pushed the c-async branch 2 times, most recently from 1e75898 to 7b994e4 Compare November 22, 2025 10:22
fmt

fmt

fix build

clippy

fmt
@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2025

Hi, how about starting a discussion about the design before add more changes in this PR?

@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Nov 22, 2025

Hi, how about starting a discussion about the design before add more changes in this PR?

ok.

here is link #6082 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bindings/c releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants