PHOENIX-7704 Integrate HBase's new Scan Latency Metrics #2291
+1,895
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 11, 2025 01:07
… memstore and block count read from FS
|
@sanjeet006py at high level, the changes look good but I think once we have hbase 2.6 release, we should create separate PR for the new module without including phoenix metrics changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phoenix-hbase-compatmodule for HBase 2.6.4 to consume the new metrics. Link to the Phoenix dev mailing list thread with alignment on creating newphoenix-hbase-compatmodule.phoenix-hbase-compat-2.6.4module is same asphoenix-hbase-compat-2.6.0except for classes:CompatScanMetricsandCompatThreadLocalServerSideScanMetrics.New metrics being added to Phoenix to be reported in query level read metrics:
frt: Time spent in reading a HBase block from HDFS/filesystem.brff: Number of bytes read from HDFS to read the HBase Block. This will be case when the HBase block is not found in block cache or the block in block cache is corrupt.brfm: Number of bytes read from memstore. Here the size of each cell read from memstore is summed.brfc: Number of bytes read from block cache. This is the size of the block and the size computations are done in same manner as if the block was read from filesystem only. Thus, helps with apples-to-apples comparison of bytes read from FS vs block cache.broc: Number of block read operations. If the HBase block was read from filesystem then this metric is also incremented by 1 per HBase block read. This along withbrffcan give better idea of overhead coming from block read when bytes read are same while HBase blocks read have increased.rsp: Time spent in RPC scan processing. This is the time spent by scan RPC call scanning the rows byRSRpcServices#scan()method.rsqw: Time spent in RPC scan queue wait. Time spent by a scan RPC call in server side call queue.