Skip to content

Fix error example of multiple-advertised-listeners #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix error example of multiple-advertised-listeners #1017

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdad4b6
Fix error example of multiple-advertised-listeners
casuallc May 28, 2025
19375a1
Update concepts-multiple-advertised-listeners.md
casuallc Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/concepts-multiple-advertised-listeners.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ PulsarClient internalSecureClient = PulsarClient.builder()

// External client with SSL
PulsarClient externalClient = PulsarClient.builder()
.serviceUrl("pulsar+ssl://external-brokers.example.com:6651")
.serviceUrl("pulsar+ssl://external-brokers.example.com:16651")
Copy link
Member

@lhotari lhotari May 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually a mistake. Earlier there's a sentence "Add a load balancer that proxies to any healthy available broker on the external listener port.". The load balancer (or rather a gateway) should map external-brokers.example.com:6651 to the internal IP address of the broker to port 16651. This should be clarified in the docs. Would you like to revisit this PR to cover that instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more addition:
If the external-brokers.example.com DNS name maps directly to the IP of the broker that it's bound to, then it should be port 16651, so there are 2 cases to cover.

Copy link
Author

@casuallc casuallc Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually a mistake. Earlier there's a sentence "Add a load balancer that proxies to any healthy available broker on the external listener port.". The load balancer (or rather a gateway) should map external-brokers.example.com:6651 to the internal IP address of the broker to port 16651. This should be clarified in the docs. Would you like to revisit this PR to cover that instead?

If 6651 is proxed to 16651, the broker should response external-brokers.example.com:16651, then client wolud connected to external-brokers.example.com:16651？

.build();
```

Expand Down