Skip to content

[SDP] [SPARK-52576] Drop/recreate on full refresh and MV update #51280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SDP] [SPARK-52576] Drop/recreate on full refresh and MV update #51280

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d527ee7
drop on full refresh
sryza Jun 25, 2025
ad8078a
remove commented-out code
sryza Jun 26, 2025
c6280c4
bring back column ordering in test assert
sryza Jul 2, 2025
6b5d7b4
switch back order
sryza Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/DatasetManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,13 @@ object DatasetManager extends Logging {
}

// Wipe the data if we need to
if ((isFullRefresh || !table.isStreamingTable) && existingTableOpt.isDefined) {
context.spark.sql(s"TRUNCATE TABLE ${table.identifier.quotedString}")
val dropTable = (isFullRefresh || !table.isStreamingTable) && existingTableOpt.isDefined
if (dropTable) {
catalog.dropTable(identifier)
}

// Alter the table if we need to
if (existingTableOpt.isDefined) {
if (existingTableOpt.isDefined && !dropTable) {
val existingSchema = existingTableOpt.get.schema()

val targetSchema = if (table.isStreamingTable && !isFullRefresh) {
Expand All @@ -198,7 +199,7 @@ object DatasetManager extends Logging {
}

// Create the table if we need to
if (existingTableOpt.isEmpty) {
if (dropTable || existingTableOpt.isEmpty) {
catalog.createTable(
identifier,
new TableInfo.Builder()
Expand Down