Skip to content

Revert "[SPARK-52576][SDP] Drop/recreate on full refresh and MV update" #51497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "[SPARK-52576][SDP] Drop/recreate on full refresh and MV update" #51497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/DatasetManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,12 @@ object DatasetManager extends Logging {
}

// Wipe the data if we need to
val dropTable = (isFullRefresh || !table.isStreamingTable) && existingTableOpt.isDefined
if (dropTable) {
catalog.dropTable(identifier)
if ((isFullRefresh || !table.isStreamingTable) && existingTableOpt.isDefined) {
context.spark.sql(s"TRUNCATE TABLE ${table.identifier.quotedString}")
}

// Alter the table if we need to
if (existingTableOpt.isDefined && !dropTable) {
if (existingTableOpt.isDefined) {
val existingSchema = v2ColumnsToStructType(existingTableOpt.get.columns())

val targetSchema = if (table.isStreamingTable && !isFullRefresh) {
Expand All @@ -200,7 +199,7 @@ object DatasetManager extends Logging {
}

// Create the table if we need to
if (dropTable || existingTableOpt.isEmpty) {
if (existingTableOpt.isEmpty) {
catalog.createTable(
identifier,
new TableInfo.Builder()
Expand Down