[SPARK-53320] Make RegisterUserDefinedTableFunction in SparkConnectPlanner side effect free #52081
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anner side effect free
heyihong
changed the title
heyihong
changed the title
heyihong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactored
RegisterUserDefinedTableFunctionhandling inSparkConnectPlannerto make it side effect free by converting it from a direct handler to a command transformation that returns aLogicalPlan.Key changes:
RegisterPythonTableFunctionCommandto encapsulate UDTF registration logicREGISTER_TABLE_FUNCTIONcase fromprocessmethod totransformCommandmethodhandleRegisterUserDefinedTableFunctiontotransformRegisterUserDefinedTableFunctionto returnLogicalPlaninstead of performing side effectsWhy are the changes needed?
The previous implementation created side effects in SparkConnectPlanner by directly registering functions. This refactoring makes UDTF registration consistent with other commands by deferring the registration to logical plan execution.
Does this PR introduce any user-facing change?
No. This is an internal refactoring that maintains the same external behavior. UDTF registration continues to work exactly as before.
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor 1.4.5