[SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE #52086
+320
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorDjelic
changed the title
miland-db
reviewed
Aug 21, 2025
sql/core/src/test/resources/sql-tests/inputs/sql-session-variables.sql
Outdated
Show resolved
Hide resolved
miland-db
approved these changes
Aug 21, 2025
davidm-db
approved these changes
Aug 22, 2025
|
cc @cloud-fan @srielau to review as well |
srielau
reviewed
Aug 22, 2025
sql/core/src/test/resources/sql-tests/analyzer-results/sql-session-variables.sql.out
Outdated
Show resolved
Hide resolved
srielau
approved these changes
Aug 22, 2025
…to the same value;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added missing tests from the sql golden file test for the multivariable DECLARE.
Missing variants were:
Why are the changes needed?
To improve the code coverage of golden files.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This patch includes only the golden file tests themselves.
Was this patch authored or co-authored using generative AI tooling?
No.