-
Couldn't load subscription status.
- Fork 28.9k
[SPARK-54006][TESTS][DSTREAM][3.5] Fix for NoClassDefFoundError in WithAggregationKinesisBackedBlockRDDSuite and KinesisTestUitls #52715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-3.5
Are you sure you want to change the base?
Conversation
…thAggregationKinesisBackedBlockRDDSuite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @vrozov . Currently, this PR has two mixed themes unlike the PR title and description.
Add explicit dependency on javax.xml.bind:jaxb-api to the test scope of Kinesis ASL.
JDK 9 and above removed javax.xml.bind package from JDK, so when test runs on JDK 9 and above it fails.
In order to help your PR get merged, I'd like to recommend to split this PR into two.
- One is only chasing
javax.xml.bind:jaxb-api(the scope of PR title and description) - The other is refactoring the code via the following.
private lazy val streamExistsWaiter = kinesisClient.waiters().streamExists()Also, cc @sarutak , too
|
@dongjoon-hyun @sarutak The primary focus of the PR is to fix |
Sorry but it literally means your PR description is insufficient because it doesn't include the code change. |
|
@dongjoon-hyun Updated title and description, please check. |
| <dependency> | ||
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>2.3.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root pom.xml defines this dep with <version>2.2.11</version> in dependencyManagement, does that version work? if so, please remove the version overriding here.
What changes were proposed in this pull request?
javax.xml.bind:jaxb-apito the test scope of Kinesis ASL.streamExistswaiter to wait for newly created Kinesis stream to become activeWhy are the changes needed?
javax.xml.bindpackage from JDK, so when test runs on JDK 9 and above it fails.ResourceNotFoundExceptionwhile sending dataDoes this PR introduce any user-facing change?
No
How was this patch tested?
with JDK 17
ENABLE_KINESIS_TESTS=1 build/mvn test -Pkinesis-asl -pl connector/kinesis-asland
ENABLE_KINESIS_TESTS=1 build/sbt -Pkinesis-aslWas this patch authored or co-authored using generative AI tooling?
No