fix: use local db model in migration #34875
Conversation
eschutho
requested review from
betodealmeida,
michael-s-molina,
mistercrunch and
sadpandajoe
as code owners
eschutho
changed the title
github-actions
bot
added
risk:db-migration
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Overly broad exception handler in database driver detection ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/migrations/shared/catalogs.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| try: | ||
| driver = url.get_driver_name() | ||
| except Exception: | ||
| driver = None |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #273f77
Actionable Suggestions - 3
-
tests/unit_tests/migrations/shared/catalogs_test.py - 3
- Missing required catalog_access permission · Line 731-744
- Unused mock function breaks test logic · Line 361-363
- SQLAlchemy metadata registry inconsistency · Line 689-691
Review Details
-
Files reviewed - 2 · Commit Range:
aec2369..fec70ea- superset/migrations/shared/catalogs.py
- tests/unit_tests/migrations/shared/catalogs_test.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
AI Code Review powered by
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
eschutho
force-pushed
the
elizabeth/fix-catalog-migration
branch
from
c6dc953 to
33ff67d
Compare
Code Review Agent Run #004fe9Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
5 participants
SUMMARY
Using a local version of the db model so that this migration can be run in the future when there are changes to the model in future versions and this older migration needs to run before the newer one.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION