fix: Improve table layout and column sizing #34887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change table layout from fixed to auto for better content fitting - Remove hardcoded column sizes to allow dynamic sizing based on content - Add max-width constraint to table cells (320px) to prevent excessive expansion - Apply background color hotfix for overflowing cells in antd tables - Retain explicit sizing only for Actions column in ChartList and Dataset column 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
the
listview
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inconsistent Column Width Behavior ▹ view | 🧠 Not in scope |
|
Fixed cell width may truncate important content ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx | ✅ |
| superset-frontend/src/pages/DashboardList/index.tsx | ✅ |
| superset-frontend/src/pages/ChartList/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| hidden: column.hidden, | ||
| key: column.id, | ||
| width: column.size ? COLUMN_SIZE_MAP[column.size] : COLUMN_SIZE_MAP.md, | ||
| width: column.size ? COLUMN_SIZE_MAP[column.size] : undefined, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| } | ||
| } | ||
| .ant-table-cell { | ||
| max-width: 320px; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kgabryje
changed the title
Contributor
|
@sadpandajoe Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
Contributor
|
@sadpandajoe Ephemeral environment spinning up at http://34.220.80.202:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
sadpandajoe
added
the
review:checkpoint
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 2, 2025
Co-authored-by: Claude <[email protected]> (cherry picked from commit 1758351)
rusackas
removed
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Test plan
🤖 Generated with Claude Code