TINKERPOP-2647 improved plugin error message in Gremlin Console

[nnmva]

https://issues.apache.org/jira/browse/TINKERPOP-2647

I was trying to fix this issue, and I found that it wasn't failing the same way as described and the console state seems to get cleaned up on its own:

gremlin> :install org.apache.tinkerpop neo4j-gremlin 3.7.4-SNAPSHOT
==>Loaded: [org.apache.tinkerpop, neo4j-gremlin, 3.7.4-SNAPSHOT] - restart the console to use [tinkerpop.neo4j]
gremlin> :plugin use tinkerpop.neo4j
==>tinkerpop.neo4j activated
gremlin> :uninstall neo4j-gremlin
==>Uninstalled neo4j-gremlin - restart the console for removal to take effect
gremlin> :x

         \,,,/
         (o o)
-----oOOo-(3)-oOOo-----
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.tinkergraph
invalid plugin: org.apache.tinkerpop.gremlin.neo4j.jsr223.Neo4jGremlinPlugin
gremlin> 

The error didn't occur for spark or neo4j, but I found that the invalid plugin message wasn't as clear as it could be. I was confused by what was happening. I would like to suggest this small change to the messaging. It clarifies the action taken by the console.

gremlin> :install org.apache.tinkerpop neo4j-gremlin 3.7.4-SNAPSHOT
==>Loaded: [org.apache.tinkerpop, neo4j-gremlin, 3.7.4-SNAPSHOT] - restart the console to use [tinkerpop.neo4j]
gremlin> :plugin use tinkerpop.neo4j
==>tinkerpop.neo4j activated
gremlin> :uninstall neo4j-gremlin
==>Uninstalled neo4j-gremlin - restart the console for removal to take effect
gremlin> :x

         \,,,/
         (o o)
-----oOOo-(3)-oOOo-----
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.tinkergraph
invalid plugin: org.apache.tinkerpop.gremlin.neo4j.jsr223.Neo4jGremlinPlugin -- removing reference to this plugin.
gremlin> 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.20%. Comparing base (9b46b67) to head (c40ba29).
Report is 349 commits behind head on 3.7-dev.

Files with missing lines	Patch %	Lines
...rg/apache/tinkerpop/gremlin/console/Console.groovy	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             3.7-dev    #3160      +/-   ##
=============================================
+ Coverage      76.14%   76.20%   +0.05%     
- Complexity     13152    13281     +129     
=============================================
  Files           1084     1091       +7     
  Lines          65160    67639    +2479     
  Branches        7285     7371      +86     
=============================================
+ Hits           49616    51542    +1926     
- Misses         12839    13369     +530     
- Partials        2705     2728      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Cole-Greer]

VOTE +1

[Cole-Greer]

Merging as CTR