TINKERPOP-3200 Made repeat() act as a global parent #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cole-Greer
reviewed
Oct 21, 2025
...-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/integrated/Paths.feature
Show resolved
Hide resolved
andreachild
reviewed
Oct 22, 2025
...ore/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Oct 22, 2025
There was a problem hiding this comment.
Would be good to add tests that cover a wider variety of the types of steps used inside repeat. For example addV, dedup, property, tail, etc.
andreachild
reviewed
Oct 22, 2025
...ore/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
Outdated
Show resolved
Hide resolved
|
VOTE +1 |
kenhuuu
force-pushed
the
TINKERPOP-3200
branch
from
c1c10be to
2772ed6
Compare
|
VOTE +1 |
andreachild
reviewed
Oct 24, 2025
kenhuuu
force-pushed
the
TINKERPOP-3200
branch
3 times, most recently
from
8d6957a to
d280d1a
Compare
spmallette
reviewed
Oct 27, 2025
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerWorld.java
Show resolved
Hide resolved
kenhuuu
force-pushed
the
TINKERPOP-3200
branch
2 times, most recently
from
1b7c422 to
bb7fadf
Compare
Co-authored-by: Cole-Greer <[email protected]>
kenhuuu
force-pushed
the
TINKERPOP-3200
branch
from
bb7fadf to
903cb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3200
Test tag @GraphComputerVerificationOrderingNotSupported temporarily added as there is an unrelated bug in OLAP repeat() that prevents these from being tested in the same way as OLTP.
VOTE +1