Skip to content

Conversation

@moonchen
Copy link
Contributor

@moonchen moonchen commented Sep 5, 2025

  • Add counters for hits to the other two kinds of memory caches that we have.
  • Add a counter for reads that miss all memory caches.
  • Change hits to the write aggregation buffer to HIT_RAM, since the aggregation buffer is RAM.

The goals of this change are:

  1. Capture all RAM cache hits in stats and logs in some way.
  2. Maintain backwards compatibility with existing log processing and stats collection.

* Add counters for hits to the other two kinds of memory caches that we have.
* Add a counter for reads that miss all memory caches.
* Change hits to the write aggregation buffer to HIT_RAM, since the aggregation buffer is RAM.

The goals of this change are:

1. Capture all RAM cache hits in stats and logs in some way.
2. Maintain backwards compatibility with existing log processing and stats collection.
Copy link
Member

@ezelkow1 ezelkow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here, after updates could see hits being logged in the agg buffer

@ezelkow1
Copy link
Member

[approve ci autest 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants