[ZEPPELIN-6308] Extract hardcoded py4j values to constants #5056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkGyeongTae
requested changes
Aug 31, 2025
Contributor
There was a problem hiding this comment.
It looks like the GitHub Action build failed due to line length errors. Could you please check and fix them?
Error: src/main/java/org/apache/zeppelin/python/PythonDockerInterpreter.java:[94] (sizes) LineLength: Line is longer than 100 characters (found 106).
Error: src/main/java/org/apache/zeppelin/python/PythonInterpreter.java:[189] (sizes) LineLength: Line is longer than 100 characters (found 103).
Error: src/main/java/org/apache/zeppelin/python/PythonInterpreter.java:[215] (sizes) LineLength: Line is longer than 100 characters (found 105).
Contributor
Author
Thanks! Fixed the line length issues by breaking the long lines to stay under 100 characters. This was my first experience with automated code style checks - really appreciate how these guidelines help maintain code quality and readability across the project! |
ParkGyeongTae
pushed a commit
that referenced
this pull request
Sep 7, 2025
### What is this PR for? This PR extracts hardcoded py4j values to constants in Python interpreters to improve maintainability. It creates a new PythonConstants class to centralize py4j version and file path constants, replacing hardcoded strings across multiple Python interpreter classes. This addresses the TODO comment requesting to avoid hardcoded py4j values. ### What type of PR is it? Refactoring ### Todos * [x] - Create PythonConstants class with py4j constants * [x] - Replace hardcoded py4j values in IPythonInterpreter * [x] - Replace hardcoded py4j values in PythonInterpreter * [x] - Replace hardcoded py4j values in PythonDockerInterpreter ### What is the Jira issue? [ZEPPELIN-6308](https://issues.apache.org/jira/browse/ZEPPELIN-6308) ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5056 from celinayk/ZEPPELIN-6308. Signed-off-by: ParkGyeongTae <[email protected]> (cherry picked from commit 4297661) Signed-off-by: ParkGyeongTae <[email protected]>
Contributor
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR extracts hardcoded py4j values to constants in Python interpreters to improve maintainability. It creates a new PythonConstants class to centralize py4j version and file path constants, replacing hardcoded strings across multiple Python interpreter classes. This addresses the TODO comment requesting to avoid hardcoded py4j values.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
ZEPPELIN-6308
How should this be tested?
Screenshots (if appropriate)
Questions: