[ZEPPELIN-6310] When paragraph to edit, word wrap doesn't work #5058
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dididy
changed the title
dididy
changed the title
tbonelee
approved these changes
Aug 31, 2025
There was a problem hiding this comment.
LGTM. For others' reference, linking the monaco-editor v0.30.1 typings:
https://github.com/microsoft/monaco-editor/blob/5a7ba61be909ae9e4889768a3453ebb0dec392e2/monaco-editor/typedoc/monaco.d.ts#L2927
tbonelee
pushed a commit
that referenced
this pull request
Sep 2, 2025
### What is this PR for? **Description:** You can check that in the Classic UI, word wrap is applied when editing an paragraph, but in the New UI it is not, which makes editing difficult. From a user’s perspective, the lack of word wrap can make editing both inconvenient and confusing, so this issue should be addressed. Also, in the case of .md files, word wrap is applied when the file is executed, but it is not applied when editing, which seems to cause an inconsistency. **[Appropriate action - Classic UI]** https://github.com/user-attachments/assets/064d883d-0b3e-44cb-9448-bc00848bae78 **[AS-IS]** https://github.com/user-attachments/assets/3084b82a-a8fd-492f-8ef0-3fa421f92e99 **[TO-BE]** https://github.com/user-attachments/assets/8b8db68b-9373-41d1-b091-57599b34a4f2 ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? * [[ZEPPELIN-6310](https://issues.apache.org/jira/browse/ZEPPELIN-6310)] ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? N * Is there breaking changes for older versions? N * Does this needs documentation? N Closes #5058 from dididy/fix/ZEPPELIN-6310. Signed-off-by: ChanHo Lee <[email protected]> (cherry picked from commit 96e2c65) Signed-off-by: ChanHo Lee <[email protected]>
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Description:
You can check that in the Classic UI, word wrap is applied when editing an paragraph, but in the New UI it is not, which makes editing difficult. From a user’s perspective, the lack of word wrap can make editing both inconvenient and confusing, so this issue should be addressed. Also, in the case of .md files, word wrap is applied when the file is executed, but it is not applied when editing, which seems to cause an inconsistency.
[Appropriate action - Classic UI]
2025-08-30.9.51.17.mov
[AS-IS]
2025-08-30.1.10.58.mov
[TO-BE]
2025-08-30.1.10.21.mov
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: