Skip to content

feat: update the DevTools 1 lesson of the JS2 course to be about JavaScript #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

honzajavorek
Copy link
Collaborator

A part of #1584

@honzajavorek honzajavorek requested a review from TC-MO June 27, 2025 13:50
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Jun 27, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: JavaScript Misclassified in Web Tech Summary

The sentence "Apart from JavaScript, websites are built with two main technologies: HTML and CSS" is factually incorrect and logically inconsistent. Websites are built with three main technologies: HTML, CSS, and JavaScript. The current phrasing incorrectly implies JavaScript is separate from the core web technologies, contradicting established web development facts and the lesson's content.

sources/academy/webscraping/scraping_basics_javascript2/01_devtools_inspecting.md#L32-L33

Apart from JavaScript, websites are built with two main technologies: HTML and CSS. In the **Elements** tab, DevTools shows the HTML and CSS of the current page:

Fix in Cursor


Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎

@apify-service-account
Copy link

Preview for this PR was built for commit 27aecab and is ready at https://pr-1654.preview.docs.apify.com!

@TC-MO
Copy link
Contributor

TC-MO commented Jul 25, 2025

Doesn't Cursor of all things raise a good point :D? We mention here two technologies, and then mention JS as something separate yet connected? But then again, we mention apart so that implies 3 technologies after all 🤔 maybe a rephrasing is in order?

@honzajavorek
Copy link
Collaborator Author

Re-reading the sentence now, I wonder why I did the change at all? The original wording sounds all right to me even for the JS course 🤷‍♂️ I guess I'll just revert to the original text for that sentence.

@apify-service-account
Copy link

Preview for this PR was built for commit d84e6dbc and is ready at https://pr-1654.preview.docs.apify.com!

@honzajavorek honzajavorek requested a review from TC-MO July 28, 2025 11:09
@apify-service-account
Copy link

Preview for this PR was built for commit 009d17bf and is ready at https://pr-1654.preview.docs.apify.com!

@honzajavorek
Copy link
Collaborator Author

@TC-MO Is this all right now? I'm missing a final verdict here.

@honzajavorek honzajavorek merged commit 5f8d102 into master Jul 30, 2025
9 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-devtools1 branch July 30, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants