-
Notifications
You must be signed in to change notification settings - Fork 117
feat: update the DevTools 1 lesson of the JS2 course to be about JavaScript #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: JavaScript Misclassified in Web Tech Summary
The sentence "Apart from JavaScript, websites are built with two main technologies: HTML and CSS" is factually incorrect and logically inconsistent. Websites are built with three main technologies: HTML, CSS, and JavaScript. The current phrasing incorrectly implies JavaScript is separate from the core web technologies, contradicting established web development facts and the lesson's content.
sources/academy/webscraping/scraping_basics_javascript2/01_devtools_inspecting.md#L32-L33
apify-docs/sources/academy/webscraping/scraping_basics_javascript2/01_devtools_inspecting.md
Lines 32 to 33 in 27aecab
Apart from JavaScript, websites are built with two main technologies: HTML and CSS. In the **Elements** tab, DevTools shows the HTML and CSS of the current page: |
Comment bugbot run
to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎
Preview for this PR was built for commit |
sources/academy/webscraping/scraping_basics_javascript2/01_devtools_inspecting.md
Outdated
Show resolved
Hide resolved
Doesn't Cursor of all things raise a good point :D? We mention here two technologies, and then mention JS as something separate yet connected? But then again, we mention |
Re-reading the sentence now, I wonder why I did the change at all? The original wording sounds all right to me even for the JS course 🤷♂️ I guess I'll just revert to the original text for that sentence. |
Preview for this PR was built for commit |
sources/academy/webscraping/scraping_basics_python/01_devtools_inspecting.md
Show resolved
Hide resolved
Preview for this PR was built for commit |
@TC-MO Is this all right now? I'm missing a final verdict here. |
A part of #1584