Skip to content

fix: Fix type of cloud_storage_client in SmartApifyStorageClient #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix: Fix type of cloud_storage_client in SmartApifyStorageClient #642

merged 1 commit into from
Oct 23, 2025

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Oct 22, 2025 •
edited
Loading

The type of cloud_storage_client in SmartApifyStorageClient should be StorageClient, not just ApifyStorageClient, as we want to support using other storage clients on the Apify platform as well.

Other minor changes:

  • I've also updated the method order for consistency: constants -> public -> private.
  • ApifyStorageClient is in single access mode by default.

@vdusek vdusek added this to the 126th sprint - Tooling team milestone Oct 22, 2025
@vdusek vdusek requested a review from Pijukatel October 22, 2025 13:54
@vdusek vdusek self-assigned this Oct 22, 2025
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 22, 2025
@vdusek vdusek merged commit 3bf285d into master Oct 23, 2025
22 checks passed
@vdusek vdusek deleted the polish-smart-apify-storage-client branch October 23, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@vdusek vdusek

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

126th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

2 participants

@vdusek @Pijukatel