Skip to content

Conversation

@Pijukatel
Copy link
Collaborator

Description

Use JsonSerializable type for user_data

Issues

@github-actions github-actions bot added this to the 114th sprint - Tooling team milestone May 7, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 7, 2025
@Pijukatel
Copy link
Collaborator Author

It seems ok according to mypy like this and unit tests are passing as well, but I am not really sure about this though. As discussed here: https://github.com/apify/crawlee-python/pull/1086/files/a67d3b3b42d2a1d59923810fe6f17dabeea3e98b#r1995086090

there are some casts down the road when it comes to user data, which makes me unsure about type checking result.

@janbuchar
Copy link
Collaborator

The reason this is uncool is that crawlee puts its own stuff into user_data (more precisely user_data['__crawlee']), and this depends on it being a dictionary. Not sure if the platform would accept anything other than a dict, too...

@Pijukatel Pijukatel closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update push_data annotations to use JsonSerializable type

3 participants