adding compress mode and checksum, as also split of symbol #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4bremer
reviewed
Sep 14, 2023
| [ PROPERTY_CHANGE, "org.demos.Echo", "message", "foo"] | ||
| // 1 is the object id of "org.demos.Echo" | ||
| // 2 is the member id of "message" | ||
| [ PROPERTY_CHANGE, 1, 2, "foo"] |
There was a problem hiding this comment.
Just to clarify this, will it be really integers or will it be integers wrapped in strings?
[ PROPERTY_CHANGE, 1, 2, "foo"] or [ PROPERTY_CHANGE, "1", "2", "foo"]
Depending on the answer we should also adapt the protocol to use integer based functions params.
Otherwise we can just use one method for both modes.
w4bremer
reviewed
Sep 14, 2023
| [ LINK, 1, CHECKSUM ] | ||
| ``` | ||
|
|
||
| There is no handshake messages, to ensure both client and services are in compress mode, this needs to be ensured during the deployment. If the client and service are not in the same mode, the link will fail, as the object identifier will not match. |
There was a problem hiding this comment.
Would it be much work to extend the link message to also sync the mode?
Bit more work now, but less headache during deployment because there would be a clear error message.
There was a problem hiding this comment.
Exchanging the protocol version would also help reduce problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
Closes #57
📑 Description