for reserved keywords add _ suffix
#155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4bremer
approved these changes
Sep 25, 2024
dorotaphanSiili
approved these changes
Sep 25, 2024
jryannel
force-pushed
the
prepend-keywords
branch
from
96649ee to
47cc881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reserved keyword is used, we now will change the into <name_> during parsing of the model. Now we also need to ensure that the filters don't remove the
_suffix.We still display a warning that the word is a reserved word.
So a name
switchwill beswitch_. This would also impact json serialization (switch_) as property name.This solution could be used to ensure that on all technologies all names will be coherent and we should have almost never breaking code, based on reserved keywords.