Skip to content

fix(lib): fix preview when container has an infinite dimension #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lib): fix preview when container has an infinite dimension #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/src/apivideo_camera_preview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,12 @@ class _ApiVideoCameraPreviewState extends State<ApiVideoCameraPreview> {
Widget _buildFittedPreview(
BoxConstraints constraints, NativeDeviceOrientation orientation) {
final orientedSize = _size.orientate(orientation);
final fittedSize =
applyBoxFit(widget.fit, orientedSize, constraints.biggest);
// See https://github.com/flutter/flutter/issues/17287
return SizedBox(
width: constraints.maxWidth,
height: constraints.maxHeight,
return Container(
width: fittedSize.destination.width,
height: fittedSize.destination.height,
child: FittedBox(
fit: widget.fit,
clipBehavior: Clip.hardEdge,
Expand Down