Skip to content

Conversation

jerelmiller
Copy link
Member

Since the incremental handler is marked as internal, I want to suggest this refactor to swap the order of chunk and cacheData arguments. This also saves a touch of bundle size.

I've also marked all existing methods on the incremental handler as @internal to ensure its obvious that the only public usage of the incremental handlers should be its constructor.

Copy link

changeset-bot bot commented Sep 16, 2025

⚠️ No Changeset found

Latest commit: 7bf939c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Sep 16, 2025

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12924

commit: 7bf939c

@apollo-librarian
Copy link

apollo-librarian bot commented Sep 16, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 22888f3f47b638a970293f82
Build Logs: View logs

@jerelmiller jerelmiller force-pushed the jerel/array-merge-strategy branch from 2a2fbc5 to 9b9d8aa Compare September 16, 2025 15:58
@jerelmiller jerelmiller force-pushed the jerel/tweak-incremental-signature branch from 1e524d3 to 278c6b7 Compare September 16, 2025 15:59
@jerelmiller jerelmiller force-pushed the jerel/array-merge-strategy branch from 9b9d8aa to b41de5f Compare September 16, 2025 16:14
@jerelmiller jerelmiller force-pushed the jerel/tweak-incremental-signature branch 2 times, most recently from 294b242 to 278c6b7 Compare September 16, 2025 16:26
@jerelmiller jerelmiller force-pushed the jerel/array-merge-strategy branch from b41de5f to c496039 Compare September 16, 2025 16:32
@jerelmiller jerelmiller force-pushed the jerel/tweak-incremental-signature branch from 278c6b7 to 7bf939c Compare September 16, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant