Added Getter and Setters for DataSet for backward compatibility of projects using com.flipkart artifact #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects which were using com.flipkart domain
📊 JaCoCo Code Coverage
|
santanusinha
requested changes
Apr 21, 2025
src/main/java/io/appform/databuilderframework/model/DataSet.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appform/databuilderframework/model/DataSet.java
Outdated
Show resolved
Hide resolved
…nto map_getters_setters
…) before giving it to external world
…erframework into map_getters_setters
santanusinha
requested changes
Apr 28, 2025
| } | ||
|
|
||
| public Set<String> keySet() { | ||
| return safeOp(() -> new HashSet<>(availableData.keySet())); |
Contributor
There was a problem hiding this comment.
This needs to be mutable?
Collaborator
Author
There was a problem hiding this comment.
Moved to immutable set
|
santanusinha
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.