Fix parsing of URLs with plus signs #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemes allow for `+`, `-` and `.` characters.
bioball
commented
Dec 1, 2025
| Bytes(1, 2, 3, 4) | ||
| } | ||
| ["absolute URI scheme with plus"] { | ||
| "Cannot find resource `foo+bar///?baz=buz`." |
Member
Author
There was a problem hiding this comment.
Prior to this fix, it was parsing the query param as the path segment. For example, this error message would look like:
Cannot find resource `foo+bar///%3Fbaz=buz`
And the query param would be lost.
HT154
pushed a commit
that referenced
this pull request
Dec 3, 2025
This fixes an issue where URLs with schemes that contain `+`, `-`, and `.` would not be parsed correctly. For example, `foo+bar:///?baz.pkl` would turn into `foo+bar:///%3Fbaz.pkl`. The query param is lost, and turned into the path.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where URLs with schemes that contain
+,-, and.would not be parsed correctly.For example,
foo+bar:///?baz.pklwould turn intofoo+bar:///%3Fbaz.pkl. The query param is lost, and turned into the path.