fix: native gvm ci #929
Closed
fix: native gvm ci #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checksums taken during apple#876 ended up out of date due to the release of GraalVM `21.1.2` (the PR was built against `21.1.1`). These checksums are calculated from the GraalVM download page directly: https://www.graalvm.org/downloads/ On Linux: ``` sha256sum graalvm-... ``` Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
sgammon
commented
Feb 4, 2025
Comment on lines
+22
to
+29
| export JAVA_ROOT="/Library/Java/JavaVirtualMachines/jdk-21.jdk" | ||
| export JAVA_HOME="$JAVA_ROOT/Contents/Home" | ||
| export PATH="$JAVA_HOME/bin:$PATH" | ||
| mv $HOME/jdk $JAVA_ROOT | ||
| /usr/libexec/java_home -V | ||
| java -version | ||
| mkdir -p $HOME/.gradle | ||
| echo "org.gradle.java.home=$JAVA_HOME" >> $HOME/.gradle/gradle.properties |
Contributor
Author
There was a problem hiding this comment.
Some notes:
JAVA_ROOTvsJAVA_HOMEaccounts for the../Contents/Homepath prepended to mac JDKs./jdkis not writable on modern macOS, so the JDK is unpacked at$HOME/jdk- I am not sure
export JAVA_HOME=...will impact subsequent steps, soorg.gradle.java.home=...is set instead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Checksum taken during JDK 21 toolchain #876 ended up out of date due to the release of GraalVM
21.1.2(the PR was built against21.1.1), which happened while the PR was being authored. The checksum forlinux-aarch64is updated.JDK 21 isn't installed within the environment under macOS. Windows and Linux already install it. Thus, a setup script is added to CI macOS jobs to install Temurin JDK 21.