Streaming gRPC client can leak responses if malformed response received #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When gRPC client receives a response, it first validates that it's formed according to gRPC specification. If any headers or trailers are missing, `validateResponseAndGetPayload` will throw an exception. In this case, we leak undrained response payload body. Modifications: 1. Try catch logic of `validateResponseAndGetPayload`, subscribe and cancel response message body in case of unexpected exceptions. 2. Enhance `ProtocolCompatibilityTest` to validate we never leak responses across all tests. Result: Responses are properly drained even when we receive malformed responses.
daschl
approved these changes
Oct 29, 2025
lawrencewang49
pushed a commit
to lawrencewang49/servicetalk
that referenced
this pull request
Oct 30, 2025
…ed (apple#3354) Motivation: When gRPC client receives a response, it first validates that it's formed according to gRPC specification. If any headers or trailers are missing, `validateResponseAndGetPayload` will throw an exception. In this case, we leak undrained response payload body. Modifications: 1. Try catch logic of `validateResponseAndGetPayload`, subscribe and cancel response message body in case of unexpected exceptions. 2. Enhance `ProtocolCompatibilityTest` to validate we never leak responses across all tests. Result: Responses are properly drained even when we receive malformed responses.
lawrencewang49
pushed a commit
to lawrencewang49/servicetalk
that referenced
this pull request
Oct 30, 2025
…ed (apple#3354) Motivation: When gRPC client receives a response, it first validates that it's formed according to gRPC specification. If any headers or trailers are missing, `validateResponseAndGetPayload` will throw an exception. In this case, we leak undrained response payload body. Modifications: 1. Try catch logic of `validateResponseAndGetPayload`, subscribe and cancel response message body in case of unexpected exceptions. 2. Enhance `ProtocolCompatibilityTest` to validate we never leak responses across all tests. Result: Responses are properly drained even when we receive malformed responses.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Oct 31, 2025
Motivation: apple#3354 introduced `ProtocolCompatibilityTest.ResponseLeakValidator`. However, the test thread that asserts `pendingRequests` counter can race with `GrpcUtils.validateResponseAndGetPayload` logic for Trailers-Only response draining that executes inside `afterOnError` callback. Modifications: - Use `CountDownLatch` to ensure all new requests were terminated. Result: Fixes apple#3356
idelpivnitskiy
added a commit
that referenced
this pull request
Oct 31, 2025
Motivation: #3354 introduced `ProtocolCompatibilityTest.ResponseLeakValidator`. However, the test thread that asserts `pendingRequests` counter can race with `GrpcUtils.validateResponseAndGetPayload` logic for Trailers-Only response draining that executes inside `afterOnError` callback. Modifications: - Use `CountDownLatch` to ensure all new requests were terminated. Result: Fixes #3356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When gRPC client receives a response, it first validates that it's formed according to gRPC specification. If any headers or trailers are missing,
validateResponseAndGetPayloadwill throw an exception. In this case, we leak undrained response payload body.Modifications:
validateResponseAndGetPayload, subscribe and cancel response message body in case of unexpected exceptions.ProtocolCompatibilityTestto validate we never leak responses across all tests.Result:
Responses are properly drained even when we receive malformed responses.