Skip to content

Change useFloyd heuristic to match comment #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change useFloyd heuristic to match comment #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/HeapModule/Heap.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ extension Heap {

guard newCount > origCount, newCount > 1 else {
// If we didn't append, or the result is too small to violate heapness,
// then we have nothing else to dp.
// then we have nothing else to do.
return
}

Expand All @@ -381,7 +381,7 @@ extension Heap {
//
// FIXME: Write a benchmark to verify this heuristic.
let heuristicLimit = 2 * newCount / newCount._binaryLogarithm()
let useFloyd = (newCount - origCount) < heuristicLimit
let useFloyd = (newCount - origCount) > heuristicLimit
_update { handle in
if useFloyd {
handle.heapify()
Expand Down
Loading