Add support for Oban timeouts #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For situations where an error is raised from the main Oban process instead of the spawned process, create an ad-hoc span instead of using an already existing one. This produces an effect like our send_error helper, which doesn't have context but makes sure the error is still reported.
Because ad-hoc exception spans in Oban don't have their context set when the span is created, set all context when handing the error.
This test ensures oban_job_exception/4 creates a span when none exists, including the metadata that would have been added to the span if it existed before the exception was raised.
|
✔️ All good! |
Because spans are now created from both oban_job_start/4 and oban_job_exeption/4, this patch adds do_oban_job_start/1, which is called from both functions.
jeffkreeftmeijer
force-pushed
the
oban-timeout
branch
from
f13ca44 to
0835f4f
Compare
"Add support for Oban timeout exceptions"
unflxw
approved these changes
Oct 8, 2025
unflxw
reviewed
Oct 8, 2025
Co-authored-by: Noemi <[email protected]>
tombruijn
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Oban timeouts weren't caught as they happen outside of any jobs. This means that there's no active span when the exception happens, resulting in the error being dropped. This patch creates a span if none exists when an exception happens, giving a send_error-like functionality to catch these errors too.
Closes #1012.