Skip to content

Conversation

hmacr
Copy link
Contributor

@hmacr hmacr commented Sep 9, 2025

Task: https://linear.app/appwrite/issue/SER-339/project-dropdown-missing-projects

Summary by CodeRabbit

  • Bug Fixes

    • Prevents the projects bottom sheet from appearing or attempting to load on non-project pages, reducing stray UI flashes and unexpected behavior.
  • Performance

    • Avoids unnecessary loading of project-related content when outside project routes, improving navigation responsiveness and reducing resource usage.

Copy link

appwrite bot commented Sep 9, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-qa
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

Appwrite has a Discord community with over 16 000 members.

Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Walkthrough

  • File updated: src/lib/components/breadcrumbs.svelte
  • The reactive declaration $: isOnProjects = page.route.id.includes('project-[region]-[project]') was removed.
  • The check for project routes was moved inside createProjectsBottomSheet as a local const isOnProjects = page.route.id.includes('project-[region]-[project]').
  • createProjectsBottomSheet now returns null early when not on a project route, gating bottom-sheet initialization.
  • The trigger via shouldReloadProjects remains; project-loading and menu-building logic are otherwise unchanged.
  • No changes to exported or public entity signatures.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change by indicating that it fixes the loading of projects in the dropdown when on project-specific routes, making it clear and specific to the main functionality being addressed.
Description Check ✅ Passed The description, while brief, directly references the relevant task tracking the missing project-dropdown behavior, ensuring it is on-topic and clearly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b98696 and 44c69ed.

📒 Files selected for processing (1)
  • src/lib/components/breadcrumbs.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build
🔇 Additional comments (1)
src/lib/components/breadcrumbs.svelte (1)

108-110: LGTM! Route check moved to appropriate location.

Moving the route check inside createProjectsBottomSheet and adding the early return makes the logic more cohesive and ensures projects are only loaded when actually needed for project routes.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hmacr/ser-339-load-projects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant