-
Notifications
You must be signed in to change notification settings - Fork 46
Accordion Table #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion Table #360
Conversation
…ron variant of accordian
|
PinkProject ID: Note Appwrite has a Discord community with over 16 000 members. |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Previews available on pkg.vc!📦
|
const widths: number[] = []; | ||
|
||
// not the most optimal, but shouldn't affect performance. | ||
const cells = tableReference.querySelectorAll('[role="row"]:first-child [role="cell"]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to avoid this?
as well as :global
styles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think we can probably avoid a global by using a template var for table's grid cols.
- we might be able to avoid
querySelectorAll
but that would require us exposing something from cell > row > table and then use it. same for settingborder-bottom: 0;
for the last cell.
Co-authored-by: Torsten Dittmann <[email protected]>
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)