Skip to content

Conversation

@nekomoto911
Copy link

@nekomoto911 nekomoto911 commented Oct 18, 2025

Description

When signers.len() <= num_peers, calling .cycle() on the signers iterator results in fetching the same peer multiple times, which leads to redundant batch request RPCs being sent to that single peer.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@nekomoto911 nekomoto911 force-pushed the opt_next_request_peers branch 4 times, most recently from 8a3d321 to 196a50e Compare October 18, 2025 06:34
@nekomoto911 nekomoto911 force-pushed the opt_next_request_peers branch from 196a50e to 8654f5b Compare October 18, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant