Skip to content

[vm] Extract abort code from the interpreter loop into a separate function #17943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[vm] Extract abort code from the interpreter loop into a separate function #17943

wants to merge 1 commit into from
+26 −20

Conversation

@mkurnikov
Copy link
Collaborator

Cuts 250 instructions from execute_code_impl (around 2-3% of the function).

Might also improve performance due to i-cache, but I wouldn't rely on this much.

georgemitenkov
georgemitenkov reviewed Oct 22, 2025
View reviewed changes
@mkurnikov mkurnikov changed the title [vm] Cut abort code from the interpreter loop into its own #[cold] function [vm] Cut abort code from the interpreter loop into a separate function Oct 22, 2025
@mkurnikov mkurnikov changed the title [vm] Cut abort code from the interpreter loop into a separate function [vm] Extract abort code from the interpreter loop into a separate function Oct 25, 2025
@mkurnikov mkurnikov enabled auto-merge (squash) October 30, 2025 16:43
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289

Compatibility test results for dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289 (PR)
1. Check liveness of validators at old version: dccc6fd7411f851b90e209fc154dd0afabb3571c
compatibility::simple-validator-upgrade::liveness-check : committed: 14423.13 txn/s, latency: 2404.25 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 469200
2. Upgrading first Validator to new version: dde1e1d93b132dfdadb4c696a4681c887fea0289
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5202.70 txn/s, latency: 6625.19 ms, (p50: 7300 ms, p70: 7500, p90: 7600 ms, p99: 7600 ms), latency samples: 180140
3. Upgrading rest of first batch to new version: dde1e1d93b132dfdadb4c696a4681c887fea0289
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5290.64 txn/s, latency: 6510.82 ms, (p50: 7300 ms, p70: 7300, p90: 7400 ms, p99: 7500 ms), latency samples: 182280
4. upgrading second batch to new version: dde1e1d93b132dfdadb4c696a4681c887fea0289
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8247.69 txn/s, latency: 4155.32 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 273440
5. check swarm health
Compatibility test for dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on dde1e1d93b132dfdadb4c696a4681c887fea0289

two traffics test: inner traffic : committed: 13686.57 txn/s, latency: 2750.18 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5204040
two traffics test : committed: 99.96 txn/s, latency: 758.19 ms, (p50: 700 ms, p70: 800, p90: 800 ms, p99: 1000 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.228, avg: 2.128", "ConsensusProposalToOrdered: max: 0.165, avg: 0.163", "ConsensusOrderedToCommit: max: 0.085, avg: 0.073", "ConsensusProposalToCommit: max: 0.249, avg: 0.236"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.73s no progress at version 5456401 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.38s no progress at version 5450055 (avg 0.32s) [limit 16].
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289

Compatibility test results for dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289 (PR)
Upgrade the nodes to version: dde1e1d93b132dfdadb4c696a4681c887fea0289
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2163.70 txn/s, submitted: 2167.89 txn/s, failed submission: 4.20 txn/s, expired: 4.20 txn/s, latency: 1385.89 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 2100 ms), latency samples: 195882
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2169.75 txn/s, submitted: 2176.17 txn/s, failed submission: 6.42 txn/s, expired: 6.42 txn/s, latency: 1349.74 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2800 ms), latency samples: 195920
5. check swarm health
Compatibility test for dccc6fd7411f851b90e209fc154dd0afabb3571c ==> dde1e1d93b132dfdadb4c696a4681c887fea0289 passed
Upgrade the remaining nodes to version: dde1e1d93b132dfdadb4c696a4681c887fea0289
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2016.16 txn/s, submitted: 2024.37 txn/s, failed submission: 8.20 txn/s, expired: 8.20 txn/s, latency: 1467.04 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 181841
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgao1996 vgao1996 vgao1996 approved these changes

@georgemitenkov georgemitenkov georgemitenkov approved these changes

@wrwg wrwg Awaiting requested review from wrwg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkurnikov @vgao1996 @georgemitenkov