fix: full SA name in Kubernetes MCP #314
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the ServiceAccount name specification in the Kubernetes MCP configuration to use the full ServiceAccount name as it appears in kubectl get sa, rather than a shortened version.
Key changes:
- Updated the
service_accountfield from"operator"to"archestra-platform-mcp-k8s-operator" - Simplified the instructions to directly state the default ServiceAccount name instead of describing a naming pattern
github-merge-queue bot
pushed a commit
to archestra-ai/archestra
that referenced
this pull request
Jan 6, 2026
If catalog entry has a `serviceAccount` field, like in Kubernetes MCP, we are using this field value as is. It can also be customized. No more `ARCHESTRA_ORCHESTRATOR_MCP_K8S_SERVICE_ACCOUNT_NAME`. Related PR in the catalog archestra-ai/website#314 MCP install modal: <img width="1512" height="858" alt="image" src="https://github.com/user-attachments/assets/f9a5812c-327a-418a-8225-b2ba0528280d" /> MCP edit modal: <img width="1512" height="854" alt="image" src="https://github.com/user-attachments/assets/15cd9eae-88d5-4812-9dc9-c9e21f79a9ff" /> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to use SA as is if it's specified, so it has to be a full name as shown in
kubectl get sa