Skip to content

I2CSlave: fix slave write regression #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged

I2CSlave: fix slave write regression #1055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9991f4
I2CSlave: fix slave write
pennam Apr 29, 2025
6ca4422
I2CSlave: restore critical section with temp buffer
pennam Apr 29, 2025
6231980
I2CSlave: do not use vla
pennam Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libraries/Wire/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ size_t arduino::MbedI2C::write(const uint8_t* data, int len) {
int arduino::MbedI2C::read() {
int rv = -1;
core_util_critical_section_enter();

if (rxBuffer.available()) {

rv = rxBuffer.read_char();
Expand Down Expand Up @@ -160,9 +159,12 @@ void arduino::MbedI2C::receiveThd() {
}
if (usedTxBuffer != 0) {
core_util_critical_section_enter();
slave->write((const char *) txBuffer, usedTxBuffer);
core_util_critical_section_exit();
uint8_t tempTxBuffer[256];
uint8_t usedTempTxBuffer = usedTxBuffer;
memcpy(tempTxBuffer, txBuffer, usedTempTxBuffer);
usedTxBuffer = 0;
core_util_critical_section_exit();
slave->write((const char *) tempTxBuffer, usedTempTxBuffer);
}
//slave->stop();
break;
Expand Down