Use standard position for non-configuration env mapping in workflow
#169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where some project-specific configuration of reusable GitHub Actions workflows must be done via workflow environment variables, the standard practice is to place the global `env` mapping near the top of the workflow to make them easily accessible to the project maintainer. However, in other cases the mapping does not contain any values that require adjustment. In this case, the established practice is to place it after the `on` mapping. Previously, the `env` mapping of the "Sync Labels" workflow was used to define the project's standard Node.js version, and thus the mapping was placed at the top of the workflow. However, this configuration was obviated by the change to defining the Node.js value in the `package.json` file. So the `env` mapping is no longer used for per-project configuration in this workflow and thus it should be moved below the `on` mapping.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where some project-specific configuration of reusable GitHub Actions workflows must be done via workflow environment variables, the standard practice is to place the global
envmapping near the top of the workflow to make them easily accessible to the project maintainer. However, in other cases the mapping does not contain any values that require adjustment. In this case, the established practice is to place it after theonmapping.Previously, the
envmapping of the "Sync Labels" workflow was used to define the project's standard Node.js version, and thus the mapping was placed at the top of the workflow. However, this configuration was obviated by the change to defining the Node.js value in thepackage.jsonfile (#124). So theenvmapping is no longer used for per-project configuration in this workflow and thus it should be moved below theonmapping.