Skip to content

Refactor Dockerfile: Add Optimizations for Building Dependencies in Dockerfile #16149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactor Dockerfile: Add Optimizations for Building Dependencies in Dockerfile #16149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions scripts/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,16 @@ MAINTAINER chriseth <[email protected]>
#Establish working directory as solidity
WORKDIR /solidity

# Build dependencies
RUN apk update && apk add boost-dev boost-static build-base cmake git clang
# Build dependencies
RUN apk update && \
apk add --no-cache --no-install-recommends \
boost-dev \
boost-static \
build-base \
cmake \
git \
clang && \
rm -rf /var/cache/apk/*
Comment on lines +9 to +17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're at refactoring the Dockerfiles, I'll just add that I'd prefer if we eventually switched to this style for multi-command RUN:

Suggested change
RUN apk update && \
apk add --no-cache --no-install-recommends \
boost-dev \
boost-static \
build-base \
cmake \
git \
clang && \
rm -rf /var/cache/apk/*
RUN <<-EOF
set -eou pipefail
apk update
apk add --no-install-recommends \
boost-dev \
boost-static \
build-base \
cmake \
git \
clang
rm -rf /var/cache/apk/*
EOF

It has less noise from continuations and && and does not require changing the snippet when it is moved to/from an .sh file.


#Copy working directory on travis to the image
COPY / $WORKDIR
Expand Down