Skip to content

Conversation

aminejebbar
Copy link

@aminejebbar aminejebbar commented May 27, 2025

Hi,
This PR adds QLoRa support with a more complete integration than the initial attempt. In particular:

  • QLoRa can be toggled on or off via config.py, making it optional and more flexible.
  • I've tested as much as I could, though I'm limited by hardware (training gets stuck on my side), but it appears functional.

Let me know if anything needs adjustment, happy to update based on feedback.

Thanks for your time!

@aminejebbar
Copy link
Author

@sergiopaniego , could you please check if my code looks correct to you?

@aminejebbar aminejebbar changed the title Feature/add qlora Add QLoRa with configuration support May 27, 2025
Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Since this task is already in progress in #13 and #16, I highly recommend that you coordinate to focus on a common PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants