Skip to content

Add length check in prepare_inputs for Groth16 verifier #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radik878 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add length check in prepare_inputs for Groth16 verifier #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use crate::{r1cs_to_qap::R1CSToQAP, Groth16};

use super::{PreparedVerifyingKey, Proof, VerifyingKey};

use ark_relations::gr1cs::Result as R1CSResult;
use ark_relations::gr1cs::{Result as R1CSResult, SynthesisError};

use core::ops::{AddAssign, Neg};

Expand All @@ -26,6 +26,12 @@ impl<E: Pairing, QAP: R1CSToQAP> Groth16<E, QAP> {
pvk: &PreparedVerifyingKey<E>,
public_inputs: &[E::ScalarField],
) -> R1CSResult<E::G1> {
// Ensure the number of provided public inputs matches the verification key query length.
// Expected: gamma_abc_g1 has 1 extra element accounting for the constant term.
if public_inputs.len() + 1 != pvk.vk.gamma_abc_g1.len() {
return Err(SynthesisError::AssignmentMissing);
}

let mut g_ic = pvk.vk.gamma_abc_g1[0].into_group();
for (i, b) in public_inputs.iter().zip(pvk.vk.gamma_abc_g1.iter().skip(1)) {
g_ic.add_assign(&b.mul_bigint(i.into_bigint()));
Expand Down