Skip to content

Conversation

Case3y
Copy link
Contributor

@Case3y Case3y commented May 12, 2023

There is a UnicodeDecodeError when I run the build script. I run the build script on my Windows system which system language is Chinese.

I think it's an encoding problem. Add encoding=utf-8 to avoid encoding issues.

屏幕截图 2023-05-12 142836

@arrowtype
Copy link
Owner

arrowtype commented Jun 23, 2023

Hey @Case3y, thanks so much for this helpful and very concise PR! I’ve tested it, and it seems to work without issue on my end. If it makes this work on your system, that is great! I’ve actually just added another with open(filepath) as file: statement to the project in #25, so I’ll go specify utf-8 there, as well.

@arrowtype arrowtype merged commit b6075af into arrowtype:main Jun 23, 2023
arrowtype added a commit that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants