Throw error on missing packages #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This does not work except on macOS. |
iloveitaly
force-pushed
the
throw-error-on-missing-packages
branch
from
caf1fba to
ac57008
Compare
iloveitaly
force-pushed
the
throw-error-on-missing-packages
branch
10 times, most recently
from
1ec7d3c to
a853944
Compare
iloveitaly
force-pushed
the
throw-error-on-missing-packages
branch
from
a853944 to
5d6b22a
Compare
Contributor
Author
|
@smorimoto looks like the non-macos script wasn't building with libjpeg/libpng at all. I've fixed this and the build is working on all platforms. |
ahawkins
approved these changes
Oct 12, 2021
Contributor
ahawkins
left a comment
ahawkins
left a comment
There was a problem hiding this comment.
Looks good. Thanks for addressing this. This bothered me as well.
ahawkins
reviewed
Oct 12, 2021
Contributor
ahawkins
left a comment
ahawkins
left a comment
There was a problem hiding this comment.
Something to nudge users toward a solution.
Indicate which packages need to be installed via brew Co-authored-by: Adam Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned here the
ASDF_PKG_MISSINGvariable doesn't actually do anything. This change actually throws an error if a package is missing.Also added a link to a blog post where I detail this out further.