forked from pydantic/pydantic-ai
-
Notifications
You must be signed in to change notification settings - Fork 0
Debug2 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KRRT7
wants to merge
48
commits into
main
Choose a base branch
from
debug2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage part instead of stringifying (pydantic#2173) Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Loïc POISOT <[email protected]>
Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com>
…c#2247) Co-authored-by: Douwe Maan <[email protected]>
… tools (pydantic#2094) Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Douwe Maan <[email protected]>
… media type (pydantic#2270) Co-authored-by: David <[email protected]>
…ient` arg (pydantic#2214) Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Douwe Maan <[email protected]>
This reverts commit c5f7702. Update uv.lock
codeflash-ai bot
added a commit
that referenced
this pull request
Jul 25, 2025
…`debug2`) Here's the optimized version of your program. The optimizations focus on. - **Avoiding repeated `guess_type` lookups.** If `_infer_media_type` is called multiple times for the same instance, cache the result, as URL and thus media type do not change during the instance lifetime. This saves on repeated computation and any internal calls. - **Micro-optimization:** Move the exception creation out of the main execution path. - **Other imports and class hierarchy** stay unchanged as per your requirements. All existing docstrings and code comments are preserved because your snippet doesn't have extra comments. **Summary of changes:** - Added `self._cached_media_type` to cache the result of mimetype guessing, improving performance when called repeatedly per instance. - No changes to the function signatures, docstrings, or visible behavior. If `_infer_media_type` is only called once per instance, the benefit is small, but if called multiple times, this saves time and avoids recomputation. This achieves optimal runtime without altering external behavior.
⚡️ Codeflash found optimizations for this PR📄 20% (0.20x) speedup for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.