feat: Add cppcheck lint aspect

[martin4861]

Add cppcheck as lint aspect as per #569.
A local test can be ran using: cd example; bazel lint //src:hello_cc
The aspect supports human readable output and xml output, e.g.
cd example; bazel build //... --aspects=//tools/lint:linters.bzl%cppcheck --output_groups=rules_lint_xml

Changes are visible to end-users: yes

• Searched for relevant documentation and updated as needed: yes
• Breaking change (forces users to change their own code or config): no
• Suggested release notes appear below: yes

"Add cppcheck linter"

Test plan

• Manual testing: cd example; bazel build //... --aspects=//tools/lint:linters.bzl%cppcheck --output_groups=rules_lint_xml: This will produce following output:

INFO: Analyzed 194 targets (0 packages loaded, 0 targets configured).
INFO: Found 194 targets...
Aspect //tools/lint:linters.bzl%cppcheck of //src:hello_cc up-to-date:
  bazel-bin/src/hello_cc.AspectRulesLintCppCheck.xml
Aspect //tools/lint:linters.bzl%cppcheck of //src/cpp/main:hello-greet up-to-date:
  bazel-bin/src/cpp/main/hello-greet.AspectRulesLintCppCheck.xml
Aspect //tools/lint:linters.bzl%cppcheck of //src:hello_c up-to-date:
  bazel-bin/src/hello_c.AspectRulesLintCppCheck.xml
Aspect //tools/lint:linters.bzl%cppcheck of //src/cpp/lib:hello-time up-to-date:
  bazel-bin/src/cpp/lib/hello-time.AspectRulesLintCppCheck.xml
Aspect //tools/lint:linters.bzl%cppcheck of //src/cpp/main:hello-world up-to-date:
  bazel-bin/src/cpp/main/hello-world.AspectRulesLintCppCheck.xml
INFO: Elapsed time: 0.227s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

[CLAassistant]

All committers have signed the CLA.

[aspect-workflows]

Test

All tests were cache hits

5 tests (100.0%) were fully cached saving 2s.

---

Test

example

8 test targets passed

Targets

//tools/format:format_test_HTML_Jinja_with_djlint [k8-fastbuild]3s
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]14s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]2s
//tools/format:format_test_Python_with_ruff [k8-fastbuild]287ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]4s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]232ms

Total test execution time was 27s. 33 tests (80.5%) were fully cached saving 14s.

---

Test (WORKSPACE) (Test)

example

8 test targets passed

Targets

//tools/format:format_test_HTML_Jinja_with_djlint [k8-fastbuild]3s
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]6s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]509ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]179ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]4s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]201ms

Total test execution time was 15s. 13 tests (61.9%) were fully cached saving 8s.

---

Lint [.]      Lint [example]

[thesayyn]

i am not sure if this okay, isn't cppcheckpremium a paid tool?

[martin4861]

That's true. There is also a free version, which can be installed with apt install cppcheck. I tried to use rules_distroless, but it does not work due to transitive dependencies. Do we need to model the tool in Bazel or can it be installed in the environment?

[martin4861]

We can use the cppcheckpremium executable. If we do not use the configuration for the premium and do not provide a license file, then the executable will behave like the free version.

[alexeagle]

adding a comment in the sources is a better way to answer the question than a comment on the PR, as the former will be discoverable by the next person who wonders if this example will work for them