Skip to content

Conversation

@assada
Copy link
Owner

@assada assada commented Aug 17, 2025

No description provided.

@assada assada requested a review from Copilot August 17, 2025 13:09
@assada assada self-assigned this Aug 17, 2025
@assada assada added the agent label Aug 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the agent factory by introducing resolver pattern for checkpointers and prompt providers, replacing direct instantiation and factory functions with centralized resolution logic.

  • Introduces CheckpointerResolver and PromptProviderResolver classes to handle runtime resolution of checkpointers and prompt providers
  • Removes the old create_checkpointer function and create_prompt_provider function in favor of resolver-based approach
  • Updates agent configuration to include checkpoint type and modifies prompt directory configuration

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/container.py Replaces checkpointer factory function with resolver and adds prompt provider resolver to dependency injection
app/bootstrap/config.py Adds prompt_root_dir configuration field with default value
app/agent/prompt_resolver.py New resolver class for managing prompt provider creation based on source type
app/agent/prompt.py Updates default prompt directory and removes old factory function
app/agent/langgraph/graph.py Removes TODO comment
app/agent/factory.py Refactors agent creation to use resolver pattern instead of direct instantiation
app/agent/config.py Updates agent config to use checkpoint_type and removes prompt_dir field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@assada assada merged commit 53fdc40 into master Aug 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants