Skip to content

Conversation

@Reaves73
Copy link

@Reaves73 Reaves73 commented May 2, 2025

add TCP models and bug patterns

@Reaves73
Copy link
Author

Reaves73 commented May 2, 2025

I made the first submission according to the professor's suggestions. I know it is not yet fully completed. There might be more revisions later. If there are any deficiencies, please point them out.

@kostis
Copy link
Contributor

kostis commented May 3, 2025

As you can see, there are some errors when running the CI tests, although they are quite easy to fix (you can just run spotless:apply and then commit the changed files).

@kostis kostis changed the title My tcp branch Add support for testing TCP implementations May 3, 2025
@Reaves73
Copy link
Author

Reaves73 commented May 3, 2025

Thank you! I’ve corrected the issues, and everything seems to be working now. II wasn’t very familiar with this process before, so I really appreciate your feedback and any further suggestions you might have.

@kostis
Copy link
Contributor

kostis commented Jul 3, 2025

This commit is clearly broken. It should be reverted.

Perhaps it's easier to reset this PR to the commit before it (4fdad8b) and redo whatever changes are necessary after that.

@Reaves73
Copy link
Author

Reaves73 commented Jul 3, 2025

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants